- notifications - lists.xwiki.org

[xwiki/xwiki-platform] d7c2f4: [Misc] Fix various SonarCloud issues (use instance...
by XWiki Notifications 17 Jul '26

17 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d7c2f49403fbca352f7db24c1577a37be33d20c4 https://github.com/xwiki/xwiki-platform/commit/d7c2f49403fbca352f7db24c1577… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-17 (Fri, 17 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/PropertyClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/DefaultDocumentAccessBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/XWikiConfigDelegate.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCache.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/converter/DocumentConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/converter/XWikiDocumentConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/display/XWikiDocumentContentAsyncParser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/doc/ListAttachmentArchive.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/event/AbstractEntityEvent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/export/DocumentSelectionResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/AbstractEntityOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/XWikiAttachmentOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/AbstractCompleteEntityReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CompactStringEntityReferenceSerializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentMixedReferenceDocumentReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentReferenceDocumentReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentReferencePageReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentWikiReferenceProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/DocumentReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/XClassRelativeStringEntityReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/objects/classes/ImplicitlyAllowedValuesDBListQueryBuilder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/AbstractXWikiEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/WikiSkinUtils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/TemplateAsyncRenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/TemplateListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/VelocityTemplateEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/velocity/DefaultVelocityEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObject.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObjectReference.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseStringProperty.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/meta/MetaClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/meta/PropertyMetaClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/DatabaseProduct.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutor.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/HibernateDataMigrationManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R1008010XWIKI10092DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R40000XWIKI6990DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R72001XWIKI12228DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/api/XWikiUser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/velocity/XWikiVelocityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/model/internal/document/SafeDocumentAuthors.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/security/authservice/internal/AuthServiceConfigurationInvalidator.java Log Message: ----------- [Misc] Fix various SonarCloud issues (use instanceof pattern matching) Replace redundant instanceof-check-and-cast with instanceof pattern matching (java:S6201) across xwiki-platform-oldcore. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[jira@xwiki.org][Issue] Updates for CPARENT-27: Release contrib parent pom based on XWiki 17.10.10
by XWiki Notifications 17 Jul '26

17 Jul '26

1 0

[xwiki-contrib/parent] 875f54: [release] Set version
by XWiki Notifications 17 Jul '26

17 Jul '26

Branch: refs/heads/17.10.x Home: https://github.com/xwiki-contrib/parent Commit: 875f54b1a04f520992af181870464da95ef245d5 https://github.com/xwiki-contrib/parent/commit/875f54b1a04f520992af18187046… Author: Alex Cotiugă <ancotiuga(a)gmail.com> Date: 2026-07-17 (Fri, 17 Jul 2026) Changed paths: M README.md M parent-commons/pom.xml M parent-platform-distribution/pom.xml M parent-platform/pom.xml M parent-rendering/pom.xml Log Message: ----------- [release] Set version To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/parent/settings/notifications

1 0

[xwiki-contrib/parent]
by XWiki Notifications 17 Jul '26

17 Jul '26

Branch: refs/tags/parent-17.10.10 Home: https://github.com/xwiki-contrib/parent To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/parent/settings/notifications

1 0

[xwiki/xwiki-platform] 07f483: [Misc] Fix various SonarCloud issues (use instance...
by XWiki Notifications 17 Jul '26

17 Jul '26

Branch: refs/heads/claude/sleepy-gates-xialoj Home: https://github.com/xwiki/xwiki-platform Commit: 07f483845c0aa749f5714b470207ab00ddab59d0 https://github.com/xwiki/xwiki-platform/commit/07f483845c0aa749f5714b470207… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-17 (Fri, 17 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/PropertyClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/DefaultDocumentAccessBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/XWikiConfigDelegate.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCache.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/converter/DocumentConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/converter/XWikiDocumentConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/display/XWikiDocumentContentAsyncParser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/doc/ListAttachmentArchive.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/event/AbstractEntityEvent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/export/DocumentSelectionResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/AbstractEntityOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/XWikiAttachmentOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/AbstractCompleteEntityReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CompactStringEntityReferenceSerializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentMixedReferenceDocumentReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentReferenceDocumentReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentReferencePageReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/CurrentWikiReferenceProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/DocumentReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/XClassRelativeStringEntityReferenceResolver.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/objects/classes/ImplicitlyAllowedValuesDBListQueryBuilder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/AbstractXWikiEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/WikiSkinUtils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/TemplateAsyncRenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/TemplateListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/VelocityTemplateEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/velocity/DefaultVelocityEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObject.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObjectReference.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseStringProperty.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/meta/MetaClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/meta/PropertyMetaClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/DatabaseProduct.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutor.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/HibernateDataMigrationManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R1008010XWIKI10092DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R40000XWIKI6990DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R72001XWIKI12228DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/api/XWikiUser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/velocity/XWikiVelocityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/model/internal/document/SafeDocumentAuthors.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/security/authservice/internal/AuthServiceConfigurationInvalidator.java Log Message: ----------- [Misc] Fix various SonarCloud issues (use instanceof pattern matching) Replace redundant instanceof-check-and-cast with instanceof pattern matching (java:S6201) across xwiki-platform-oldcore. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 16 Jul '26

16 Jul '26

Branch: refs/heads/claude/vigilant-dirac-qib2zr Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 220d2e: [Misc] Fix various SonarCloud issues (unused priva...
by XWiki Notifications 16 Jul '26

16 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 220d2e999d87f5e7899386052aed955cdb9d43cf https://github.com/xwiki/xwiki-platform/commit/220d2e999d87f5e7899386052aed… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-17 (Fri, 17 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-mail/xwiki-platform-legacy-mail-send/xwiki-platform-legacy-mail-send-storage/src/main/java/org/xwiki/mail/script/DeprecatedMailStorageScriptService.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-messagestream/xwiki-platform-legacy-messagestream-api/src/main/java/org/xwiki/messagestream/GroupMessageDescriptor.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/i18n/i18n.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/web/XWikiConfigurationService.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-storage/src/main/java/org/xwiki/mail/script/MailStorageScriptService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWikiConstant.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/LazyXWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/BaseClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/util/TOCGenerator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/EditForm.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiResourceManagerImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java A xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/XWikiPluginManagerTest.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarAttachmentModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarClassModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarClassPropertyModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarDocumentModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarObjectModel.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/model/XarObjectPropertyModel.java Log Message: ----------- [Misc] Fix various SonarCloud issues (unused private code and utility-class constructors) Mechanical, behaviour-preserving SonarCloud cleanups across several modules: * java:S1118 - add a private constructor to utility classes * java:S1144 - remove unused private methods (and orphaned fields/imports) * java:S1185 - remove overrides that only delegate to super Sibling of the DeprecatedMailStorageScriptService cleanup, spotted in review: the private loadMessage() helper is unused; remove it and its now-orphaned javax.mail.Session / javax.mail.internet.MimeMessage imports. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 5171ff: [Misc] Remove unused private loadMessage() in Mail...
by XWiki Notifications 16 Jul '26

16 Jul '26

Branch: refs/heads/claude/vigilant-dirac-qib2zr Home: https://github.com/xwiki/xwiki-platform Commit: 5171ff932f549b51b77051ac234a0bce84792bd1 https://github.com/xwiki/xwiki-platform/commit/5171ff932f549b51b77051ac234a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-16 (Thu, 16 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-storage/src/main/java/org/xwiki/mail/script/MailStorageScriptService.java Log Message: ----------- [Misc] Remove unused private loadMessage() in MailStorageScriptService (SonarCloud java:S1144) Sibling of the DeprecatedMailStorageScriptService cleanup, spotted in review: the private loadMessage() helper is unused; remove it and its now-orphaned javax.mail.Session / javax.mail.internet.MimeMessage imports. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 8f5c74: [Misc] Add XWikiPluginManager test for getDeclared...
by XWiki Notifications 16 Jul '26

16 Jul '26

Branch: refs/heads/claude/vigilant-dirac-qib2zr Home: https://github.com/xwiki/xwiki-platform Commit: 8f5c74d2cd3fa6c9d2f0744ce7cb8a56864961ab https://github.com/xwiki/xwiki-platform/commit/8f5c74d2cd3fa6c9d2f0744ce7cb… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-16 (Thu, 16 Jul 2026) Changed paths: A xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/XWikiPluginManagerTest.java Log Message: ----------- [Misc] Add XWikiPluginManager test for getDeclaredMethods dispatch Pins the contract that broke in this PR: a plugin is dispatched a handler function only if its concrete class declares (overrides) that method, since initPlugin() scans getDeclaredMethods() which excludes inherited methods. A plugin that only inherits endParsing() must not receive the callback. This would have caught the earlier regression of removing the skinx overrides. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 744c87: [Misc] Revert S1185 removal of plugin overrides th...
by XWiki Notifications 16 Jul '26

16 Jul '26

Branch: refs/heads/claude/vigilant-dirac-qib2zr Home: https://github.com/xwiki/xwiki-platform Commit: 744c87722392b2d40c6856550aca66724b4b2944 https://github.com/xwiki/xwiki-platform/commit/744c87722392b2d40c6856550aca… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-16 (Thu, 16 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/fileupload/FileUploadPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/PackagePlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractDocumentSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/CssResourceSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/CssSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/CssSkinFileExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/JsResourceSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/JsSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/JsSkinFileExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/LinkExtensionPlugin.java Log Message: ----------- [Misc] Revert S1185 removal of plugin overrides that only call super XWikiPluginManager.initPlugin() registers a plugin for a function name only if that method is in the plugin class's getDeclaredMethods(), which excludes inherited methods. So a skinx/plugin override that merely calls super is NOT redundant: it exists so the plugin manager dispatches that function to the class. Restore those overrides; keep only the S1185 removals in non-plugin classes (no reflective dispatch), where a pure super-call override is safe to remove. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0