[xwiki/xwiki-platform] fa6a76: XWIKI-24642: REST pages in a space resource empty ...
Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-platform Commit: fa6a7655510704ef3cbd2926924b33dffe8809fd https://github.com/xwiki/xwiki-platform/commit/fa6a7655510704ef3cbd2926924b3... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java Log Message: ----------- XWIKI-24642: REST pages in a space resource empty when ordered by date on Oracle * Fix the compilation of the cherry-picked functional test: it used the JUnit 5 assertion API, while AbstractHttpIT is still based on JUnit 4 on this branch. Also make the test method public, JUnit 4 rejects non-public test methods. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Commit: 445b75a3d8ca35135de5aad5c2c774301d62c4b1 https://github.com/xwiki/xwiki-platform/commit/445b75a3d8ca35135de5aad5c2c77... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/WikisResourceIT.java Log Message: ----------- XWIKI-24643: Several REST resources return results in arbitrary, unstable order * Fix the compilation of the cherry-picked functional tests: they used the JUnit 5 assertion API, while AbstractHttpIT is still based on JUnit 4 on this branch. Also make the test methods public, JUnit 4 rejects non-public test methods. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Commit: 7c06de65d94f0a58a41bc23ecb0f4380656f210e https://github.com/xwiki/xwiki-platform/commit/7c06de65d94f0a58a41bc23ecb0f4... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorElement.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorsDropdown.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/RealtimeEditToolbar.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/VersionElement.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/pom.xml M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/src/test/it/org/xwiki/realtime/wysiwyg/test/ui/RealtimeWYSIWYGEditorIT.java Log Message: ----------- XWIKI-22178: RealtimeWYSIWYGEditorIT#editWithSelf is flickering * Look up the coeditor element on each access in CoeditorElement, retrying while it is stale, so that the accessors of a single coeditor survive the coeditor list updates that happen when someone joins or leaves the editing session. * Read the whole list from a single lookup and retry all of it when a coeditor element goes stale in the middle, so that a list accessor returns a consistent snapshot of the coeditor list rather than a mix of several updates. This can't go through CoeditorElement, which looks up and retries each access on its own and would hide the updates. The logic is shared in CoeditorElement#readCoeditors, together with static accessors reading the identifier and the avatar hint of a coeditor element. * Replace RealtimeEditToolbar#getVisibleCoeditors with #getVisibleCoeditorCount and #getVisibleCoeditorIds, which is all it was used for, so that callers can't hold coeditor elements across an update. #isEditingAlone now also reads the count and the identifier from the same snapshot. * Fix the selector used by CoeditorsDropdown#getCoeditor, which looked for the identifier on the dropdown itself instead of on the coeditor, so it could never match. * Declare xwiki-platform-realtime-wysiwyg-ui explicitly in the docker test module. It was only reachable as an optional dependency of xwiki-platform-ckeditor-ui, which Maven doesn't resolve into the local repository, so the running wiki fetched it and the realtime webjars below it from the remote snapshot repository, silently testing the last CI snapshot instead of the locally built code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 0828edd19e2863e7011ce05b1dd2256f2c275a0f) Compare: https://github.com/xwiki/xwiki-platform/compare/9a423211737b...7c06de65d94f To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications