[xwiki/xwiki-platform] 3eb0de: XWIKI-22178: RealtimeWYSIWYGEditorIT#editWithSelf ...
Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 3eb0deaefc8908ec0b18d773d7c762aeb76271b4 https://github.com/xwiki/xwiki-platform/commit/3eb0deaefc8908ec0b18d773d7c76... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorElement.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorsDropdown.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/RealtimeEditToolbar.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/VersionElement.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/pom.xml M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/src/test/it/org/xwiki/realtime/wysiwyg/test/ui/RealtimeWYSIWYGEditorIT.java Log Message: ----------- XWIKI-22178: RealtimeWYSIWYGEditorIT#editWithSelf is flickering * Look up the coeditor element on each access in CoeditorElement, retrying while it is stale, so that the accessors of a single coeditor survive the coeditor list updates that happen when someone joins or leaves the editing session. * Read the whole list from a single lookup and retry all of it when a coeditor element goes stale in the middle, so that a list accessor returns a consistent snapshot of the coeditor list rather than a mix of several updates. This can't go through CoeditorElement, which looks up and retries each access on its own and would hide the updates. The logic is shared in CoeditorElement#readCoeditors, together with static accessors reading the identifier and the avatar hint of a coeditor element. * Replace RealtimeEditToolbar#getVisibleCoeditors with #getVisibleCoeditorCount and #getVisibleCoeditorIds, which is all it was used for, so that callers can't hold coeditor elements across an update. #isEditingAlone now also reads the count and the identifier from the same snapshot. * Fix the selector used by CoeditorsDropdown#getCoeditor, which looked for the identifier on the dropdown itself instead of on the coeditor, so it could never match. * Declare xwiki-platform-realtime-wysiwyg-ui explicitly in the docker test module. It was only reachable as an optional dependency of xwiki-platform-ckeditor-ui, which Maven doesn't resolve into the local repository, so the running wiki fetched it and the realtime webjars below it from the remote snapshot repository, silently testing the last CI snapshot instead of the locally built code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 0828edd19e2863e7011ce05b1dd2256f2c275a0f) Commit: f5d424e58ebcb600af5b8be2d7ce3db8c7413729 https://github.com/xwiki/xwiki-platform/commit/f5d424e58ebcb600af5b8be2d7ce3... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java Log Message: ----------- XWIKI-24642: REST pages in a space resource empty when ordered by date on Oracle * Fix the compilation of the cherry-picked functional test: it used the JUnit 5 assertion API and getUtil(), while AbstractHttpIT is still based on JUnit 4 and exposes TestUtils in a field on this branch. Also make the test method public, JUnit 4 rejects non-public test methods. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Commit: ed6e6a073ec969e83b593bb6acb945be0f68a0d0 https://github.com/xwiki/xwiki-platform/commit/ed6e6a073ec969e83b593bb6acb94... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/WikisResourceIT.java Log Message: ----------- XWIKI-24643: Several REST resources return results in arbitrary, unstable order * Fix the compilation of the cherry-picked functional tests: they used the JUnit 5 assertion API and getUtil(), while AbstractHttpIT is still based on JUnit 4 and exposes TestUtils in a field on this branch. Also make the test methods public, JUnit 4 rejects non-public test methods. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Compare: https://github.com/xwiki/xwiki-platform/compare/54cc6c430b6f...ed6e6a073ec9 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications