Hi Sergiu. Sergiu Dumitriu wrote:
Some other USE flags I'd like to see: src - for checking out the sources, too. You could check the status on "ant src.dist" There are standard use flag "source". xwiki ebuild use core/src/main/java sources. Current ant src.dist target make only doc, lib (no need in 'source' flag IMHO), and some resources but no sources. I think it is wrong behavior.
doc - runs "ant doc" and places the generated documentation in /usr/share/docs/xwiki/ ok
test - runs the tests, too ok
I don't like the fact that it uses the 1.0 branch. It is not something stable, I don't recall any ebuilds using something dynamic as the source. We could have some other USE flags for this. An ebuild should always have a stable tagged source, meaning that an ebuild will have the used xwiki version. So the first ebuild could be called xwiki-1.0.RC4 (or we can wait for 1.0), which checkouts sources in xwiki/tags/XWIKI_1_0_RC4. ok. In next version i will use stable tag.
We can override this with USE=trunk, which will checkout the sources from trunk. I think it is better to use a separate ebuild for trunk version (xwiki-svn-9999.ebuild for example). Some ebuilds do so (sys-apps/initng-9999).
Another option which will be needed shortly is USE=mvn, which compiles everything with maven. It is much harder. maven2 building in gentoo has some problems. It is using only in java-experimental overlay and very experimental :). There are even (failed:() GSoC07 project in support maven2 in ebuilds :) Some ebuilds using build.xml generated by maven. http://overlays.gentoo.org/proj/java/wiki/Maven_Notes I think in ebuild for 1.0.* maven2 support is minor. If I find some time, I will look at maven2 status in java-experimental overlay.
What exactly does "/etc/init.d/xwiki start/stop" do? Init script will start/stop jetty in standalone xwiki. /usr/share/xwiki-svn-1.0/standalone/ For now it is use following command: su - xwiki -c "${JAVA} ${JETTY_OPTS} -jar start.jar" >> \ /var/log/xwiki.log 2>&1 & Maybe it is not best variant. jetty-5.1.3-r1.ebuild in java-overlay uses /extra/unix/bin/jetty.sh script which I find not in xwiki standalone.
What is the default build target? Or the user has to choose at least one of war, tomcat...? Default ant build target = release. But if user do not select any use flags he gets only /usr/share/xwiki*/lib/xwiki.jar :) We need to consider default behavior for this ebuild.
Thanks for feedback. -- Artem Melentyev, UralSU, CS401