On 04/05/2012 02:37 PM, Fabio Mancinelli wrote:
On Thu, Apr 5, 2012 at 8:32 PM, savitha sundaramurthy <savitha.s131@gmail.com> wrote:
Hi Paul,
On Thu, Apr 5, 2012 at 1:52 AM, Paul Libbrecht<paul@hoplahup.net> wrote:
Ok, so this is a little script reporting usage. It looks ok but I need to touch software.
My code is here:
https://github.com/savee1/xwiki-platform/tree/SOLR/xwiki-platform-core/xwiki...
I could not build your project because of checkstyle errors. Could you fix that?
Also, I insist on forking for me to see the diffs.
I have forked the code, Sent a pull request to fabio. My commit and the list of diffs for all the files.
Yep I've seen it, though I don't think it's the correct way to proceed. The pull request, in fact, is sent to a branch of a fork in my account.
I think that this kind of development should be done in a more "institutional" place like xwiki-contrib.
Moreover, since I am not the mentor for this project, I am not entitled to merge pull requests.
So I propose to open a fork of xwiki-platform in xwiki-contrib, and that Savitha works on that fork and (re)send pull requests there.
WDYT?
That won't work, there is a fork already, and github only allows one fork per user (or organization). Let's follow the github philosophy, which is "be social" and work on Savitha's personal fork for the moment. -- Sergiu Dumitriu http://purl.org/net/sergiu/