[xwiki-devs] [Contrib] New repo and JIRA for an OpenStreetMap macro
Hi devs, We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think? If you agree, the proposed repo name and JIRA would be: - Repo: macro-openstreetmap - JIRA project: OSM [1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro Thank you, Stéphane -- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Stephane,
On 26 Jun 2018, at 20:37, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi devs,
We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think?
Since this is not a large “component”, I think my preferences goes to a single {{map}} macro, with a “provider” parameter (provider=“google”, “openstreetmap”, “apple”, etc) and possibly aliases such as {{googlemap}} {{openstreetmap}} which would simply be shortcuts for {{map provider=“google”}} and {{map provider=“openstreetmap”}}. I think it would make it simpler from a user POV. I’d prefer to have one recommended map macro that we try to support instead of a myriad of smaller map macros that would not be recommended and at various levels of support. WDYT? Thanks -Vincent
If you agree, the proposed repo name and JIRA would be:
- Repo: macro-openstreetmap - JIRA project: OSM
[1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro
Thank you,
Stéphane
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Stéphane, One of the very interesting derivative of OpenStreetMap is umap http://umap.openstreetmap.fr That’d be yet another provider, right? paul On 26 Jun 2018, at 20:44, Vincent Massol wrote:
Hi Stephane,
On 26 Jun 2018, at 20:37, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi devs,
We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think?
Since this is not a large “component”, I think my preferences goes to a single {{map}} macro, with a “provider” parameter (provider=“google”, “openstreetmap”, “apple”, etc) and possibly aliases such as {{googlemap}} {{openstreetmap}} which would simply be shortcuts for {{map provider=“google”}} and {{map provider=“openstreetmap”}}.
I think it would make it simpler from a user POV. I’d prefer to have one recommended map macro that we try to support instead of a myriad of smaller map macros that would not be recommended and at various levels of support.
WDYT?
Thanks -Vincent
If you agree, the proposed repo name and JIRA would be:
- Repo: macro-openstreetmap - JIRA project: OSM
[1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro
Thank you,
Stéphane
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Paul, uMap is very interesting indeed. It uses the same JavaScript library as the one I intend to use for our macro: LeafletJS <https://leafletjs.com/>. Technically, we'd have several tile providers for the OpenStreetMap database such as the ones listed at <https://wiki.openstreetmap.org/wiki/Tile_servers>: openstreetmap, openstreetmapfr, openseamap etc. and the ones provided by Mapbox. Note that uMap provides a Django layer for creating collaborative maps: <https://github.com/umap-project/django-leaflet-storage>. We could think of an XWiki layer along the same lines... Cheers Stéphane Paul Libbrecht:
Stéphane,
One of the very interesting derivative of OpenStreetMap is umap http://umap.openstreetmap.fr That’d be yet another provider, right?
paul
On 26 Jun 2018, at 20:44, Vincent Massol wrote:
Hi Stephane,
On 26 Jun 2018, at 20:37, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi devs,
We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think?
Since this is not a large “component”, I think my preferences goes to a single {{map}} macro, with a “provider” parameter (provider=“google”, “openstreetmap”, “apple”, etc) and possibly aliases such as {{googlemap}} {{openstreetmap}} which would simply be shortcuts for {{map provider=“google”}} and {{map provider=“openstreetmap”}}.
I think it would make it simpler from a user POV. I’d prefer to have one recommended map macro that we try to support instead of a myriad of smaller map macros that would not be recommended and at various levels of support.
WDYT?
Thanks -Vincent
If you agree, the proposed repo name and JIRA would be:
- Repo: macro-openstreetmap - JIRA project: OSM
[1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro
Thank you,
Stéphane
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Do we have the plan of being able to configure the openstreetmap provider ? Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr> On Wed, Jun 27, 2018 at 9:27 AM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Paul,
uMap is very interesting indeed. It uses the same JavaScript library as the one I intend to use for our macro: LeafletJS <https://leafletjs.com/>. Technically, we'd have several tile providers for the OpenStreetMap database such as the ones listed at <https://wiki.openstreetmap.or g/wiki/Tile_servers>: openstreetmap, openstreetmapfr, openseamap etc. and the ones provided by Mapbox. Note that uMap provides a Django layer for creating collaborative maps: <https://github.com/umap-proje ct/django-leaflet-storage>. We could think of an XWiki layer along the same lines...
Cheers
Stéphane
Paul Libbrecht:
Stéphane,
One of the very interesting derivative of OpenStreetMap is umap http://umap.openstreetmap.fr That’d be yet another provider, right?
paul
On 26 Jun 2018, at 20:44, Vincent Massol wrote:
Hi Stephane,
On 26 Jun 2018, at 20:37, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi devs,
We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think?
Since this is not a large “component”, I think my preferences goes to a single {{map}} macro, with a “provider” parameter (provider=“google”, “openstreetmap”, “apple”, etc) and possibly aliases such as {{googlemap}} {{openstreetmap}} which would simply be shortcuts for {{map provider=“google”}} and {{map provider=“openstreetmap”}}.
I think it would make it simpler from a user POV. I’d prefer to have one recommended map macro that we try to support instead of a myriad of smaller map macros that would not be recommended and at various levels of support.
WDYT?
Thanks -Vincent
If you agree, the proposed repo name and JIRA would be:
- Repo: macro-openstreetmap - JIRA project: OSM
[1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro
Thank you,
Stéphane
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap provider ?
My plan is to add two parameters to the macro: - "tiles" for configuring the tile provider URL scheme. Examples: https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png http://{s}.tile.stamen.com/toner/{z}/{x}/{y}.png - "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Stéphane, Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT? Alex On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi, The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr> On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com> wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Alex, Ludo, all, Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker: https://github.com/xwiki-contrib/macro-map/pull/9 As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances... Stéphane Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com> wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Yes I'm +1 to move to OSM being the default Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr> On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap
provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Stephane and all, I see in your last commit: M src/main/resources/MapMacro/Code/GoogleMap.xml M src/main/resources/MapMacro/Code/LeafletMap.xml M src/main/resources/XWiki/MapMacro.xml M src/main/resources/XWiki/MapMacroTranslations.fa.xml M src/main/resources/XWiki/MapMacroTranslations.fr.xml M src/main/resources/XWiki/MapMacroTranslations.hr.xml M src/main/resources/XWiki/MapMacroTranslations.sk.xml M src/main/resources/XWiki/MapMacroTranslations.xml I’m thinking that maybe we should put all the pages in the same space for the MapMacro. Right now we usually put Macros in the Macros space as a best practice. Usually those wiki macros have a singe wiki page. So I’m proposing to have all the Map Macro pages located in Macros.MapMacro.* WDYT? If we agree we should also add this to https://dev.xwiki.org/xwiki/bin/view/Community/ApplicationDevelopmentBestPra... Thanks -Vincent
On 2 Jul 2018, at 17:42, Ludovic Dubost <ludovic@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap
provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Vincent, The minimal XWiki version supported by the Map Macro is XWiki 5.4-2 and we can't use nested pages, for the moment. MapMacro space as parent sounds good. Thanks, Alex On Mon, Jul 2, 2018 at 7:37 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Stephane and all,
I see in your last commit:
M src/main/resources/MapMacro/Code/GoogleMap.xml M src/main/resources/MapMacro/Code/LeafletMap.xml M src/main/resources/XWiki/MapMacro.xml M src/main/resources/XWiki/MapMacroTranslations.fa.xml M src/main/resources/XWiki/MapMacroTranslations.fr.xml M src/main/resources/XWiki/MapMacroTranslations.hr.xml M src/main/resources/XWiki/MapMacroTranslations.sk.xml M src/main/resources/XWiki/MapMacroTranslations.xml
I’m thinking that maybe we should put all the pages in the same space for the MapMacro.
Right now we usually put Macros in the Macros space as a best practice. Usually those wiki macros have a singe wiki page.
So I’m proposing to have all the Map Macro pages located in Macros.MapMacro.*
WDYT?
If we agree we should also add this to https://dev.xwiki.org/xwiki/ bin/view/Community/ApplicationDevelopmentBestPractices
Thanks -Vincent
On 2 Jul 2018, at 17:42, Ludovic Dubost <ludovic@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă < alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have
one
implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière < slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap > provider ? > > My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://
{s}.
tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer. GoogleMutant/demo.html
Stéphane
Ludovic
> > -- > *Ludovic Dubost* > *Founder and CEO* > ludovic@xwiki.com > skype: ldubost > Blog: http://blog.ludovic.orgTry XWiki on the cloud > <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: > Secure > realtime Wysiwyg Editing <https://cryptpad.fr> > > > -- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Hi Alex, I think we could up that minimal requirement to 7.x or even 8.x. WDYT? Thanks -Vincent
On 9 Jul 2018, at 13:37, Alex Cotiugă <alexandru.cotiuga@xwiki.com> wrote:
Hi Vincent,
The minimal XWiki version supported by the Map Macro is XWiki 5.4-2 and we can't use nested pages, for the moment. MapMacro space as parent sounds good.
Thanks, Alex
On Mon, Jul 2, 2018 at 7:37 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Stephane and all,
I see in your last commit:
M src/main/resources/MapMacro/Code/GoogleMap.xml M src/main/resources/MapMacro/Code/LeafletMap.xml M src/main/resources/XWiki/MapMacro.xml M src/main/resources/XWiki/MapMacroTranslations.fa.xml M src/main/resources/XWiki/MapMacroTranslations.fr.xml M src/main/resources/XWiki/MapMacroTranslations.hr.xml M src/main/resources/XWiki/MapMacroTranslations.sk.xml M src/main/resources/XWiki/MapMacroTranslations.xml
I’m thinking that maybe we should put all the pages in the same space for the MapMacro.
Right now we usually put Macros in the Macros space as a best practice. Usually those wiki macros have a singe wiki page.
So I’m proposing to have all the Map Macro pages located in Macros.MapMacro.*
WDYT?
If we agree we should also add this to https://dev.xwiki.org/xwiki/ bin/view/Community/ApplicationDevelopmentBestPractices
Thanks -Vincent
On 2 Jul 2018, at 17:42, Ludovic Dubost <ludovic@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă < alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have
one
implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière < slauriere@xwiki.com> wrote:
Ludovic Dubost: > > Do we have the plan of being able to configure the openstreetmap >> provider ? >> >> > My plan is to add two parameters to the macro: > > - "tiles" for configuring the tile provider URL scheme. Examples: > https:// > {s}.tile.openstreetmap.org/{z}/{x}/{y}.png > <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> > <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http:// {s}. > tile.stamen.com/toner/{z}/{x}/{y}.png > <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> > <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> > > > - "library" for choosing the JavaScript library to be used: either > "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile > URL is not needed as it's necessarily the one by Google and it's > configured > by the library itself. It "leaflet" is chosen, it remains possible to > use > Google Maps tiles (not sure the macro will support it though): > https://ivansanchez.gitlab.io/Leaflet.GridLayer. GoogleMutant/demo.html > > Stéphane > > Ludovic > >> >> -- >> *Ludovic Dubost* >> *Founder and CEO* >> ludovic@xwiki.com >> skype: ldubost >> Blog: http://blog.ludovic.orgTry XWiki on the cloud >> <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: >> Secure >> realtime Wysiwyg Editing <https://cryptpad.fr> >> >> >> > -- > Stéphane Laurière > XWiki www.xwiki.com > @slauriere > > >
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
Many thanks to Alex for the ongoing code review. As for the minimal XWiki version requirement: due to my limited experience, I have (of course) no strong feeling. I have updated the version to "2.0" to reflect a change in the default settings as suggested by Thomas. Considering 1) the amount of testing needed to make sure that the macro works fine with versions 5.x and 6.x, 2) the fact that it's good practice to put all macros in a common space, I would tend to favor a compatibility with an XWiki version supporting nested pages, but let me know what you prefer and I'll be happy to proceed. Cheers, Stéphane Vincent Massol:
Hi Alex,
I think we could up that minimal requirement to 7.x or even 8.x.
WDYT?
Thanks -Vincent
On 9 Jul 2018, at 13:37, Alex Cotiugă <alexandru.cotiuga@xwiki.com> wrote:
Hi Vincent,
The minimal XWiki version supported by the Map Macro is XWiki 5.4-2 and we can't use nested pages, for the moment. MapMacro space as parent sounds good.
Thanks, Alex
On Mon, Jul 2, 2018 at 7:37 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Stephane and all,
I see in your last commit:
M src/main/resources/MapMacro/Code/GoogleMap.xml M src/main/resources/MapMacro/Code/LeafletMap.xml M src/main/resources/XWiki/MapMacro.xml M src/main/resources/XWiki/MapMacroTranslations.fa.xml M src/main/resources/XWiki/MapMacroTranslations.fr.xml M src/main/resources/XWiki/MapMacroTranslations.hr.xml M src/main/resources/XWiki/MapMacroTranslations.sk.xml M src/main/resources/XWiki/MapMacroTranslations.xml
I’m thinking that maybe we should put all the pages in the same space for the MapMacro.
Right now we usually put Macros in the Macros space as a best practice. Usually those wiki macros have a singe wiki page.
So I’m proposing to have all the Map Macro pages located in Macros.MapMacro.*
WDYT?
If we agree we should also add this to https://dev.xwiki.org/xwiki/ bin/view/Community/ApplicationDevelopmentBestPractices
Thanks -Vincent
On 2 Jul 2018, at 17:42, Ludovic Dubost <ludovic@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă < alexandru.cotiuga@xwiki.com > wrote:
Hi Stéphane, > > Why would you change the default from googlemaps? Since we only have one > implementation so far, I think we should keep it as default. WDYT? > > Alex > > On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière < slauriere@xwiki.com> > wrote: > > Ludovic Dubost: >> >> Do we have the plan of being able to configure the openstreetmap >>> provider ? >>> >>> >> My plan is to add two parameters to the macro: >> >> - "tiles" for configuring the tile provider URL scheme. Examples: >> https:// >> {s}.tile.openstreetmap.org/{z}/{x}/{y}.png >> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> >> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http:// {s}. >> tile.stamen.com/toner/{z}/{x}/{y}.png >> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> >> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> >> >> >> - "library" for choosing the JavaScript library to be used: either >> "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile >> URL is not needed as it's necessarily the one by Google and it's >> configured >> by the library itself. It "leaflet" is chosen, it remains possible to >> use >> Google Maps tiles (not sure the macro will support it though): >> https://ivansanchez.gitlab.io/Leaflet.GridLayer. GoogleMutant/demo.html >> >> Stéphane >> >> Ludovic >> >>> >>> -- >>> *Ludovic Dubost* >>> *Founder and CEO* >>> ludovic@xwiki.com >>> skype: ldubost >>> Blog: http://blog.ludovic.orgTry XWiki on the cloud >>> <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: >>> Secure >>> realtime Wysiwyg Editing <https://cryptpad.fr> >>> >>> >>> >> -- >> Stéphane Laurière >> XWiki www.xwiki.com >> @slauriere >> >> >> >
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
I also think it's better to push for OSM as the default. You might want to name the next release "2.0" to make this breaking change more explicit. On Mon, Jul 2, 2018 at 5:42 PM, Ludovic Dubost <ludovic@xwiki.com> wrote:
Yes I'm +1 to move to OSM being the default
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap
provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Thomas Mortagne
Hi Vincent, Hi all, Vincent Massol:
Hi Stephane,
On 26 Jun 2018, at 20:37, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi devs,
We have a MapMacro already [1], for displaying Google Maps. I'd like to create a distinct one for creating maps based on OpenStreetMap. Another option would be to enhance the existing MapMacro for supporting the display of OSM maps in addition, but this would make the code more complex, and in general an administrator willing to use maps in his wiki is likely to opt for one map type, probably not both, what do you think?
Since this is not a large “component”, I think my preferences goes to a single {{map}} macro, with a “provider” parameter (provider=“google”, “openstreetmap”, “apple”, etc) and possibly aliases such as {{googlemap}} {{openstreetmap}} which would simply be shortcuts for {{map provider=“google”}} and {{map provider=“openstreetmap”}}.
I think it would make it simpler from a user POV. I’d prefer to have one recommended map macro that we try to support instead of a myriad of smaller map macros that would not be recommended and at various levels of support.
It makes sense indeed :-) Thanks for your feedback I'll push an updated MapMacro asap Cheers Stéphane
WDYT?
Thanks -Vincent
If you agree, the proposed repo name and JIRA would be:
- Repo: macro-openstreetmap - JIRA project: OSM
[1] https://extensions.xwiki.org/xwiki/bin/view/Extension/Map%20Macro
Thank you,
Stéphane
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
participants (6)
-
Alex Cotiugă -
Ludovic Dubost -
Paul Libbrecht -
Stéphane Laurière -
Thomas Mortagne -
Vincent Massol