Yes I'm +1 to move to OSM being the default Ludovic -- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr> On Mon, Jul 2, 2018 at 4:31 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Hi Alex, Ludo, all,
Thanks for your feedbacks. I created a pull request which now includes OSM geocoding and opens OSM directions when clicking on the marker:
https://github.com/xwiki-contrib/macro-map/pull/9
As for the default value, now that OSM geocoding is supported I'd rather be for using it but on the other hand it's true that it will have an impact on existing instances...
Stéphane
Ludovic Dubost:
Hi,
The idea was to push for usage of OSM instead of Google, especially with the changes Google is giving and the fact that it requires a key by default. Now indeed this is unsual to change the default as it might break the cases where geocoding was used until we support geocoding as part of the OSM macro
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
On Mon, Jul 2, 2018 at 1:24 PM, Alex Cotiugă <alexandru.cotiuga@xwiki.com
wrote:
Hi Stéphane,
Why would you change the default from googlemaps? Since we only have one implementation so far, I think we should keep it as default. WDYT?
Alex
On Wed, Jun 27, 2018 at 3:13 PM, Stéphane Laurière <slauriere@xwiki.com> wrote:
Ludovic Dubost:
Do we have the plan of being able to configure the openstreetmap
provider ?
My plan is to add two parameters to the macro:
- "tiles" for configuring the tile provider URL scheme. Examples: https:// {s}.tile.openstreetmap.org/{z}/{x}/{y}.png <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> http://{s}. tile.stamen.com/toner/{z}/{x}/{y}.png <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png> <http://tile.stamen.com/toner/%7Bz%7D/%7Bx%7D/%7By%7D.png>
- "library" for choosing the JavaScript library to be used: either "leaflet" (default) or "googlemaps". If "googlemaps" is chosen, the tile URL is not needed as it's necessarily the one by Google and it's configured by the library itself. It "leaflet" is chosen, it remains possible to use Google Maps tiles (not sure the macro will support it though): https://ivansanchez.gitlab.io/Leaflet.GridLayer.GoogleMutant/demo.html
Stéphane
Ludovic
-- *Ludovic Dubost* *Founder and CEO* ludovic@xwiki.com skype: ldubost Blog: http://blog.ludovic.orgTry XWiki on the cloud <http://www.xwiki.com/en/products/try-xwiki-cloud> - Try Cryptpad: Secure realtime Wysiwyg Editing <https://cryptpad.fr>
-- Stéphane Laurière XWiki www.xwiki.com @slauriere
-- Stéphane Laurière XWiki www.xwiki.com @slauriere