July 2007 - xwiki-devs@xwiki.org

Change of SVN externals for trunks-users
by Vincent Massol 26 Jul '07

26 Jul '07

Hi, I'm about to modify the SVN externals definition for trunks-users so that they point to our own XWiki readonly SVN repo instead of pointing to the OW repo as there are issues with it. If you have checked out trunks-users, then do a svn update once I've made the change. Hopefully that'll just work. If not, you might need to do a new checkout. Sorry for that Thanks -Vincent

3 5

[VOTE] Include Foxwiki project in our main source tree and vote Rick Kenney as committer for it
by Vincent Massol 26 Jul '07

26 Jul '07

Hi, Rick Kenney has fixed the Foxwiki plugin available in our sandbox (it was initially created by Robin Fernandes - Site is here: http:// soal.xwiki.com/xwiki/bin/view/Code/FoXWiki) Rick has tried to contact Robin without success so far. We need to find out under what license it is. But assuming the license is correct and Robin agrees, I'd like us to vote on including it as part of our releases. This means we are agreeing to maintaining it. Rick has agreed to maintain it, so if we agree I'll vote to get him write access to it so that he can be the maintainer for it. If we agree on this, I propose the following: 1) Rick creates a JIRA issue in the XWiki Platform project for now, component "Other" and attach his working version to it 2) I create the extension area for foxwiki in our SVN and apply your patch there. I had already proposed such an area which we also need for the Eclipse integration. 3) I also create the maven build for it so that it can be built as part of our CI 4) I create a JIRA project for it and move your issue to it 5) I do a release of it (version 1.0) with maven in our remote maven repo 6) I create an extension page for it on xwiki.org (in the Code Zone, Extension section) and link to the download location on our remote maven repo 7) I create a blog post on xwiki.org to announce the new project and the availability of the 1.0 version 8) From there on, people create JIRA issues for it in its jira project and Rick acts on them. I can act as the release manager whenever a new version is ready Here's my +1 for both including Foxwiki and voting Rick as committer for *that* project only. Thanks -Vincent

3 3

[VOTE] Postpone XWiki 1.1M4 by one week?
by Vincent Massol 26 Jul '07

26 Jul '07

Hi developers, I'm on semi-holiday next week and I'll have only limited internet connectivity so it's going to be difficult to upload the 500MB that are required when performing a release. I can see 3 options: 1) Someone else does the release 2) I do the release on this coming Friday (the 27th) 3) We postpone by one week the release (6th of August) As 1.1M4 is our last release before the RCs start, I think the best is to postpone it by one week so that we have more time to add new features into it. However I'd like the 1.1M5 (to be renamed 1.1RC1) to remain slated for the 20th of August. So here's my +1 for postponing by 1 week the 1.1M4 release (unless someone else want to do the release but I doubt it :)). Thanks -Vincent

5 6

What is password of Xwiki repository through SVN?
by Sarfraz ASHFAQ 25 Jul '07

25 Jul '07

Hello all I am currently working as Engineer in INRIA and we are working on XWIKI.When i want to get XWiki source using Console of my linux , i provided following coomand svn co svn://svn.forge.objectweb.org/svnroot/xwiki/trunks-devs But if require a password from me.Can you tell me please what is password for it? Waiting for Answer Sarfraz Inria , France

5 8

Re: [xwiki-commits] r4015 - in xwiki-platform: core/trunk/src/main/java/com/xpn/xwiki/render/macro web/trunk/standard/src/main/webapp/tiny_mce/themes/wikieditor web/trunk/standard/src/main/webapp/tiny_mce/themes/wikieditor/images web/trunk/standard/src/main/webapp/wiki_editor web/trunk/standard/src/main/webapp/wiki_editor/plugins web/trunk/standard/src/main/webapp/wiki_editor/themes
by Vincent Massol 25 Jul '07

25 Jul '07

Hi Nam, You've modified the style macro to add a new align parameter. For this you need: 1) A separate JIRA issue! 2) To update the documentation on http://www.xwiki.org/xwiki/bin/view/ Code/StyleMacro Can you please implement both? Thanks -Vincent On Jul 24, 2007, at 1:25 PM, Phung Hai Nam wrote: > Author: namphunghai > Date: 2007-07-24 13:25:45 +0200 (Tue, 24 Jul 2007) > New Revision: 4015 > > Added: > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifycenter.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyfull.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyleft.gif > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyright.gif > Modified: > xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java > xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js > xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js > Log: > Fixed XWIKI 370 : to be able to justify text left center right full > > Modified: xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/ > render/macro/StyleMacro.java > =================================================================== > --- xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/core/trunk/src/main/java/com/xpn/xwiki/render/ > macro/StyleMacro.java 2007-07-24 11:25:45 UTC (rev 4015) > @@ -50,6 +50,7 @@ > String type = params.get("type"); > String id = params.get("id"); > String classes = params.get("class"); > + String align = params.get("align"); > String name = params.get("name"); > String size = params.get("font-size"); > String font = params.get("font-family"); > @@ -117,6 +118,9 @@ > if ((!"none".equals(name)) && (name != null) && (!"".equals > (name.trim()))) { > str.append("name=\"" + name.trim() + "\" "); > } > + if ((!"none".equals(align)) && (align != null) && > (!"".equals(align.trim()))) { > + str.append("align=\"" + align.trim() + "\" "); > + } > > str.append("style=\""); > > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > tiny_mce/themes/wikieditor/editor_template.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js 2007-07-24 07:42:22 UTC (rev > 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/editor_template.js 2007-07-24 11:25:45 UTC (rev > 4015) > @@ -258,8 +258,59 @@ > template['height'] = 250; > > tinyMCE.openWindow(template, {editor_id : editor_id, inline : > "yes"}); > - return true; > + return true; > > + case "JustifyLeft": > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'left'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyLeft", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyCenter": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'center'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyCenter", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyRight": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'right'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyRight", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > + case "JustifyFull": > + > + var focusElm = > tinyMCE.selectedInstance.getFocusElement(); > + if (focusElm && (focusElm.nodeName == "P")) { > + tinyMCE.execInstanceCommand(editor_id, > "FormatBlock", false, "<div>"); > + var selectedElm = > tinyMCE.selectedInstance.selection.getFocusElement(); > + selectedElm.setAttribute('align', 'justify'); > + } else { > + return wikiEditor.execCommand(editor_id, > element, "justifyFull", user_interface, value); > + } > + tinyMCE.triggerNodeChange(); > + return true; > + > default : > return wikiEditor.execCommand(editor_id, element, > command, user_interface, value); > } > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifycenter.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifycenter.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyfull.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyfull.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyleft.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyleft.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Added: xwiki-platform/web/trunk/standard/src/main/webapp/tiny_mce/ > themes/wikieditor/images/justifyright.gif > =================================================================== > (Binary files differ) > > > Property changes on: xwiki-platform/web/trunk/standard/src/main/ > webapp/tiny_mce/themes/wikieditor/images/justifyright.gif > ___________________________________________________________________ > Name: svn:mime-type > + application/octet-stream > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/plugins/core.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > plugins/core.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -80,6 +80,7 @@ > this.addToolbarHandler('handleHorizontalRuleButtons'); > this.addToolbarHandler('handleSupAndSubButons'); > this.addToolbarHandler('handleTableButtons'); > + this.addToolbarHandler('handleAlignButtons'); > > // Add Comands and Fix Commands(workarounds) > this.addCommand('Title', 'titleCommand'); > @@ -392,6 +393,47 @@ > tinyMCE.switchClass(editor_id + '_table', 'mceButtonNormal', > false); > } > > +WikiEditor.prototype.handleAlignButtons = function(editor_id, > node, undo_index, undo_levels, visual_aid, any_selection) { > + tinyMCE.switchClass(editor_id + '_justifyleft', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifyright', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonNormal'); > + tinyMCE.switchClass(editor_id + '_justifyfull', > 'mceButtonNormal'); > + > + var alignNode = node; > + var breakOut = false; > + do { > + if (!alignNode.getAttribute || !alignNode.getAttribute > ('align')) > + continue; > + > + switch (alignNode.getAttribute('align').toLowerCase()) { > + case "left": > + tinyMCE.switchClass(editor_id + '_justifyleft', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "right": > + tinyMCE.switchClass(editor_id + '_justifyright', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "middle": > + case "center": > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonSelected'); > + breakOut = true; > + break; > + > + case "justify": > + tinyMCE.switchClass(editor_id + '_justifyfull', > 'mceButtonSelected'); > + breakOut = true; > + break; > + } > + } while (!breakOut && (alignNode = alignNode.parentNode) != > null); > + > + var div = tinyMCE.getParentElement(node, "div"); > + if (div && div.style.textAlign == "center") > + tinyMCE.switchClass(editor_id + '_justifycenter', > 'mceButtonSelected'); > +} > + > WikiEditor.prototype.handleTitlesList = function(editor_id, node, > undo_index, undo_levels, visual_aid, any_selection) { > var list = document.getElementById(editor_id + "_titleSelect"); > if(list) { > @@ -578,6 +620,29 @@ > return str; > } > > +WikiEditor.prototype.getJustifyToolbar = function() { > + return this.getJustifyControls('justifyleft') + > this.getJustifyControls('justifycenter') + this.getJustifyControls > ('justifyright') + this.getJustifyControls('justifyfull'); > +} > + > +WikiEditor.prototype.getJustifyControls = function(button_name) { > + var str = ""; > + switch (button_name) { > + case 'justifyleft': > + str = this.createButtonHTML('justifyleft', > 'justifyleft.gif', 'lang_justifyleft_desc', 'JustifyLeft'); > + break; > + case 'justifycenter': > + str = this.createButtonHTML('justifycenter', > 'justifycenter.gif', 'lang_justifycenter_desc', 'JustifyCenter'); > + break; > + case 'justifyright' : > + str = this.createButtonHTML('justifyright', > 'justifyright.gif', 'lang_justifyright_desc', 'JustifyRight'); > + break; > + case 'justifyfull' : > + str = this.createButtonHTML('justifyfull', > 'justifyfull.gif', 'lang_justifyfull_desc', 'JustifyFull'); > + break; > + } > + return str; > +} > + > WikiEditor.prototype.getSupAndSubToolbar = function() { > return this.getSupAndSubControls('sup') + > this.getSupAndSubControls('sub'); > } > @@ -705,6 +770,7 @@ > '<option value="3">{$lang_wiki_title_3}</option>' + > '<option value="4">{$lang_wiki_title_4}</option>' + > '<option value="5">{$lang_wiki_title_5}</option>' + > + '<option value="6">{$lang_wiki_title_6}</option>' + > '</select>'; > } > > @@ -1130,7 +1196,7 @@ > WikiEditor.prototype.convertStyleExternal = function(regexp, > result, content) { > var str = ""; > var atts = result[1].split("|"); > - var tag = "font", style = "", myclass = "", id = "", name = > "", doc = ""; > + var tag = "font", style = "", myclass = "", id = "", name = > "", doc = "", align = ""; > var hasIcon = false; > for (var i=0; i < atts.length; i++) { > var att = this.trimString(atts[i].substring(0, atts > [i].indexOf("="))); > @@ -1147,6 +1213,9 @@ > else if (att == "type") { > tag = value; > } > + else if (att == "align") { > + align = value; > + } > else if (att == "icon") { > style += "background-image: url(" + value + ");"; > hasIcon = true; > @@ -1166,6 +1235,9 @@ > if (name != "") { > str += " name=\"" + name + "\""; > } > + if (align != "") { > + str += " align=\"" + align + "\""; > + } > if (style != "") { > str += " style=\"" + style + "\""; > } > @@ -1193,6 +1265,9 @@ > if (attributes["id"]) { > str += "|id=" + attributes["id"] ; > } > + if (attributes["align"]) { > + str += "|align=" + attributes["align"] ; > + } > if (attributes["class"] && attributes["class"] != > "stylemacro") { > str += "|class=" + attributes["class"] ; > } > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/themes/default.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > themes/default.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -21,6 +21,9 @@ > case "texttoolbar": > str += this.getTextToolbar(); > break; > + case "justifytoolbar": > + str += this.TOOLBAR_SPACER + this.getJustifyToolbar > (); > + break; > case "listtoolbar": > str += this.TOOLBAR_SPACER + this.getListToolbar(); > break; > > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > wiki_editor/wiki_editor.js > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js 2007-07-24 07:42:22 UTC (rev 4014) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/wiki_editor/ > wiki_editor.js 2007-07-24 11:25:45 UTC (rev 4015) > @@ -76,7 +76,7 @@ > params["use_linkeditor_tabs"] = "wiki_tab, web_tab, > attachments_tab, email_tab, file_tab"; > } > if((params["wiki_editor_toolbar"] == null) || (params > ["wiki_editor_toolbar"].toString() == "")) { > - params["wiki_editor_toolbar"] = "texttoolbar, listtoolbar, > indenttoolbar, undotoolbar, titletoolbar, styletoolbar, " > + params["wiki_editor_toolbar"] = "texttoolbar, > justifytoolbar, listtoolbar, indenttoolbar, undotoolbar, > titletoolbar, styletoolbar, " > + "horizontaltoolbar, > symboltoolbar, attachmenttoolbar, macrostoolbar, tabletoolbar, " > + "tablerowtoolbar, > tablecoltoolbar, linktoolbar"; > } > > > > -- > You receive this message as a subscriber of the xwiki- > commits(a)objectweb.org mailing list. > To unsubscribe: mailto:xwiki-commits-unsubscribe@objectweb.org > For general help: mailto:sympa@objectweb.org?subject=help > ObjectWeb mailing lists service home page: http://www.objectweb.org/ > wws

1 0

removeSpace RPC & Xeclipse
by Asiri Rathnayake 25 Jul '07

25 Jul '07

Hi All, We were silent for few days due to mid-semester work load (still have some unfinished business). Anyway, I have added the removeSpace RPC to xwiki back-end. But now i'm having few doubts about it. The remove space RPC works by retrieving all the page names under the given space and deleting them individually. But following complications may happen when using this RPC, 1. If the user does not have enough privileges to delete some of the pages within that space, an exception will be thrown half-way down. Now the RPC invoker does not know which pages were removed and which were not. (Thus, he is out of sync with the wiki) 2. If instead we chose to remove page by page from the client - Xeclipse (say), we don't have this problem , and we could even display a progress bar. (to indicate that pages are being deleted). Since the XML RPC API requires the removeSpace() RPC, we must indeed add it. But wouldn't it be better if we do not use this RPC within Xeclipse (due to reasons mentioned above) ? Or, is there a better way to implement removeSpace() RPC ? (like checking privileges before doing anything ?) ) (+ How ? ) Thanks a lot. Best Regards, - Asiri

3 13

Re: [xwiki-commits] r4023 - xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/it/com/xpn/xwiki/it
by Vincent Massol 25 Jul '07

25 Jul '07

Hi Catalin, On Jul 25, 2007, at 12:25 PM, Catalin Hritcu wrote: > Author: hritcu > Date: 2007-07-25 12:25:45 +0200 (Wed, 25 Jul 2007) > New Revision: 4023 > > Modified: > xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/ > it/com/xpn/xwiki/it/DeletePageTest.java > Log: > Test for the presence of bug XWIKI-1388 (the test currently fails) > > Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ > src/test/it/com/xpn/xwiki/it/DeletePageTest.java > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ > test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 08:45:50 > UTC (rev 4022) > +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ > test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 10:25:45 > UTC (rev 4023) > @@ -109,6 +109,18 @@ > } > } > > + /* > + * This tests for regression of XWIKI-1388 > + */ This should be a javadoc I think. > + public void testUserStaysLoggedInWhileDeleting() > + { > + logInAndCreatePageToBeDeleted("DeleteTest"); > + clickDeletePage(); > + > + assertTrue("The interface should not show the user as > logged out while deleting", > + isAuthenticated()); > + } > + I don't think we should commit test that make the build fail. We should commit them at the same time as we commit the fix IMO. When you don't have the implementation ready, then I suggest putting them in the JIRA issue related to the problem. That's what I did in the past. WDYT? Thanks -Vincent

2 1

Problem with some files names on Windows
by Thomas Mortagne 24 Jul '07

24 Jul '07

Hi, I checkouted "trunks-users" on Windows XP with TortoiseSVN and see that some files mark has modified or non versioned. I checked with Repo-browser (tools provided by TortoiseSVN) and see that theses problems appear with files containing a blank at the end. Theses names are not supported by Windows that automatically delete all ending blanks. It can be corrected with mentioned Repo-browser or on system that support blank ending files names. -- Thomas Mortagne

4 4

Future roadmap
by Sergiu Dumitriu 24 Jul '07

24 Jul '07

Hi all, The 1.1 deadline is approaching fast, and we still have a lot of issues marked as bugs, and 2.0 is contouring very slowly. Thus, I think we will need to decide whether we will have other 1.x releases or start working on 2.0 Here are some factors I see: - 2.0 will be mostly a rewrite from scratch, so all the existing bugs will probably be fixed in 2.0 - Since there will be many differences between 2.0 and 1.x, we should have a 1.x version without major known bugs, for those that don't want to upgrade to 2.0 - We have a limited manpower, so working on both branches will be hard - We will (probably) hire some new developers in the near future, so we could split the people in two branches, if we must - 2.0 will offer many new features that people are already asking for, so we shouldn't delay it much longer. I think we should make XWiki 1.2, but not more. Sergiu -- http://purl.org/net/sergiu

2 2

[Proposal] New notification implementation
by Vincent Massol 24 Jul '07

24 Jul '07

For those interested I've sent a patch for implementing a new notification mechanism. It's available here: http://jira.xwiki.org/jira/browse/XWIKI-1522 I'd love to get feedback on this. Here's what I say in there: " At the place where you want to register for an event: getObservationManager().addListener(new DocumentSaveEvent ("DocumentToWatch"), listener); At the place where you want to receive for an event: public class MyListener implements EventListener { public void onEvent(Event event, Object source, Object data) { ... } } At the place where you want to fire notifications to event listeners: getObservationManager().notify(new DocumentSaveEvent("SomeDocument"), "some source", "some data"); It's easily extensible and you can create all sorts of events as it's fully generic. " Have a look at the implementation. You'll see I have even introduced the notion of EventFilter so that we can have regex when registering interest for an event. Thanks -Vincent

4 4